DBC Parser - Fix yacc warnings #1082
Conversation
|
I don't see any difference when building from this branch, but I also don't see %type warnings, only shift/reduce conflicts. |
|
Yeah- that's it. Up to you if you want to include it.
Don't know enough at the moment to tackle the shift/reduce issues.
//.
…On Thu, 21 Nov 2024 at 23:28, Michael Balzer ***@***.***> wrote:
I don't see any difference when building from this branch, but I also
don't see %type warnings, only shift/reduce conflicts.
—
Reply to this email directly, view it on GitHub
<#1082 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABNANUAJAR22P2VUOVVYFT2BX3Y7AVCNFSM6AAAAABR5NDXSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJRGUZTSOBXGI>
.
You are receiving this because you authored the thread.Message ID:
<openvehicles/Open-Vehicle-Monitoring-System-3/pull/1082/c2491539872@
github.com>
|
|
I meant I also don't see %type warnings without this change, so these seem to be a local issue of your build environment? |
|
Ooh. Weird. Maybe a more recent version of yacc?
Hold off until you get the warnings if you want :)
…On Tue, 26 Nov 2024, 18:24 Michael Balzer, ***@***.***> wrote:
I meant I also don't see %type warnings without this change, so these seem
to be a local issue of your build environment?
—
Reply to this email directly, view it on GitHub
<#1082 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABNANRL7J3SYY6SBMZ6BIL2CRD4TAVCNFSM6AAAAABR5NDXSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBQGIZDQNJXGY>
.
You are receiving this because you authored the thread.Message ID:
<openvehicles/Open-Vehicle-Monitoring-System-3/pull/1082/c2500228576@
github.com>
|
|
Here are the warnings I get: YACC dbc_parser.y |
|
I've recently updated my OS yet still only get the shift/reduce conflict: That's all.
|
|
Mine is
bison (GNU Bison) 3.8.2
from package
Ubuntu:24.04/noble [amd64]
From: Michael Balzer ***@***.***>
Sent: Saturday, 11 January 2025 7:20 PM
To: openvehicles/Open-Vehicle-Monitoring-System-3 ***@***.***>
Cc: Michael ***@***.***>; Author ***@***.***>
Subject: Re: [openvehicles/Open-Vehicle-Monitoring-System-3] DBC Parser - Fix yacc warnings (PR #1082)
I've recently updated my OS yet still only get the shift/reduce conflict:
YACC dbc_parser.y
/home/balzer/esp/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/dbc/src/dbc_parser.y: warning: 6 shift/reduce conflicts [-Wconflicts-sr]
That's all.
YACC is bison in POSIX yacc emulation mode on my system, and bison is:
bison (GNU Bison) 3.0.4
—
Reply to this email directly, view it on GitHub <#1082 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABNANT2SRNHV5QVQNHZNJT2KD45XAVCNFSM6AAAAABR5NDXSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVGIYDOOJRGU> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
There are some warnings in the %type definitions for yacc which I believe this fixes.
I'm not knowledgeable about yacc/flex files, however I believe this is a valid fix.